-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support HTTP compression on stats/prometheus #3201
Merged
arkodg
merged 3 commits into
envoyproxy:main
from
zufardhiyaulhaq:support-compression-prometheus
Apr 18, 2024
+220
−6
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
137 changes: 137 additions & 0 deletions
137
internal/xds/bootstrap/testdata/render/enable-prometheus-gzip-compression.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| admin: | ||
| access_log: | ||
| - name: envoy.access_loggers.file | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog | ||
| path: /dev/null | ||
| address: | ||
| socket_address: | ||
| address: 127.0.0.1 | ||
| port_value: 19000 | ||
| layered_runtime: | ||
| layers: | ||
| - name: global_config | ||
| static_layer: | ||
| envoy.restart_features.use_eds_cache_for_ads: true | ||
| re2.max_program_size.error_level: 4294967295 | ||
| re2.max_program_size.warn_level: 1000 | ||
| dynamic_resources: | ||
| ads_config: | ||
| api_type: DELTA_GRPC | ||
| transport_api_version: V3 | ||
| grpc_services: | ||
| - envoy_grpc: | ||
| cluster_name: xds_cluster | ||
| set_node_on_first_message_only: true | ||
| lds_config: | ||
| ads: {} | ||
| resource_api_version: V3 | ||
| cds_config: | ||
| ads: {} | ||
| resource_api_version: V3 | ||
| static_resources: | ||
| listeners: | ||
| - name: envoy-gateway-proxy-ready-0.0.0.0-19001 | ||
| address: | ||
| socket_address: | ||
| address: 0.0.0.0 | ||
| port_value: 19001 | ||
| protocol: TCP | ||
| filter_chains: | ||
| - filters: | ||
| - name: envoy.filters.network.http_connection_manager | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager | ||
| stat_prefix: eg-ready-http | ||
| route_config: | ||
| name: local_route | ||
| virtual_hosts: | ||
| - name: prometheus_stats | ||
| domains: | ||
| - "*" | ||
| routes: | ||
| - match: | ||
| prefix: /stats/prometheus | ||
| route: | ||
| cluster: prometheus_stats | ||
| typed_per_filter_config: | ||
| envoy.filters.http.compression: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.compressor.v3.CompressorPerRoute | ||
| compressor_library: | ||
| name: text_optimized | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.compression.gzip.compressor.v3.Gzip | ||
| http_filters: | ||
| - name: envoy.filters.http.health_check | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.health_check.v3.HealthCheck | ||
| pass_through_mode: false | ||
| headers: | ||
| - name: ":path" | ||
| string_match: | ||
| exact: /ready | ||
| - name: envoy.filters.http.router | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router | ||
| clusters: | ||
| - name: prometheus_stats | ||
| connect_timeout: 0.250s | ||
| type: STATIC | ||
| lb_policy: ROUND_ROBIN | ||
| load_assignment: | ||
| cluster_name: prometheus_stats | ||
| endpoints: | ||
| - lb_endpoints: | ||
| - endpoint: | ||
| address: | ||
| socket_address: | ||
| address: 127.0.0.1 | ||
| port_value: 19000 | ||
| - connect_timeout: 10s | ||
| load_assignment: | ||
| cluster_name: xds_cluster | ||
| endpoints: | ||
| - load_balancing_weight: 1 | ||
| lb_endpoints: | ||
| - load_balancing_weight: 1 | ||
| endpoint: | ||
| address: | ||
| socket_address: | ||
| address: envoy-gateway | ||
| port_value: 18000 | ||
| typed_extension_protocol_options: | ||
| envoy.extensions.upstreams.http.v3.HttpProtocolOptions: | ||
| "@type": "type.googleapis.com/envoy.extensions.upstreams.http.v3.HttpProtocolOptions" | ||
| explicit_http_config: | ||
| http2_protocol_options: | ||
| connection_keepalive: | ||
| interval: 30s | ||
| timeout: 5s | ||
| name: xds_cluster | ||
| type: STRICT_DNS | ||
| transport_socket: | ||
| name: envoy.transport_sockets.tls | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext | ||
| common_tls_context: | ||
| tls_params: | ||
| tls_maximum_protocol_version: TLSv1_3 | ||
| tls_certificate_sds_secret_configs: | ||
| - name: xds_certificate | ||
| sds_config: | ||
| path_config_source: | ||
| path: "/sds/xds-certificate.json" | ||
| resource_api_version: V3 | ||
| validation_context_sds_secret_config: | ||
| name: xds_trusted_ca | ||
| sds_config: | ||
| path_config_source: | ||
| path: "/sds/xds-trusted-ca.json" | ||
| resource_api_version: V3 | ||
| overload_manager: | ||
| refresh_interval: 0.25s | ||
| resource_monitors: | ||
| - name: "envoy.resource_monitors.global_downstream_max_connections" | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.resource_monitors.downstream_connections.v3.DownstreamConnectionsConfig | ||
| max_active_downstream_connections: 50000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the BTP API instantiated this as a list
gateway/api/v1alpha1/backendtrafficpolicy_types.go
Line 99 in d162184
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could 1 envoy route support multiple compression libraries? AFAIK we need to select only 1 library right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it to list but limit maxitem to 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that doesn't make sense IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think envoy can support multiple compressor libraries per route, which is the argument for making it a list
but realistically the persona who creates the EnvoyProxy resource with this setting, also knows beforehand the compression supported by the peer, so a single scalar value is fine here