Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean envoygateway validate methods #3997

Merged
merged 2 commits into from
Aug 5, 2024

remove file provider part

7203618
Select commit
Loading
Failed to load commit list.
Merged

refactor: clean envoygateway validate methods #3997

remove file provider part
7203618
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 4, 2024 in 1s

67.67% (target 60.00%)

View this Pull Request on Codecov

67.67% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (c2c705b) to head (7203618).

Files Patch % Lines
api/v1alpha1/validation/envoygateway_validate.go 88.76% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3997      +/-   ##
==========================================
+ Coverage   67.59%   67.67%   +0.07%     
==========================================
  Files         183      183              
  Lines       22446    22471      +25     
==========================================
+ Hits        15173    15207      +34     
+ Misses       6193     6185       -8     
+ Partials     1080     1079       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.