Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decouple gateway status updates from the reconciler #4767

Merged
merged 27 commits into from
Dec 12, 2024

release note

fb00fb0
Select commit
Loading
Failed to load commit list.
Merged

fix: decouple gateway status updates from the reconciler #4767

release note
fb00fb0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

66.31% (target 60.00%)

View this Pull Request on Codecov

66.31% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 76.82927% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (9b60a67) to head (fb00fb0).

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 57.14% 9 Missing ⚠️
internal/provider/kubernetes/status.go 71.42% 4 Missing and 2 partials ⚠️
internal/infrastructure/runner/runner.go 0.00% 2 Missing ⚠️
internal/provider/kubernetes/kubernetes.go 93.33% 0 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4767      +/-   ##
==========================================
+ Coverage   66.24%   66.31%   +0.06%     
==========================================
  Files         209      209              
  Lines       31922    31950      +28     
==========================================
+ Hits        21148    21188      +40     
+ Misses       9523     9512      -11     
+ Partials     1251     1250       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.