Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12] Adding scheduled shutdown service #206

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

[#12] Adding scheduled shutdown service #206

wants to merge 1 commit into from

Conversation

DT3264
Copy link
Collaborator

@DT3264 DT3264 commented Sep 3, 2023

[#12] Adding scheduled shutdown service

This commit adds support for a new global directive "ShutdownTime", like ContestTimes or ConfigExpirationTime, that schedules a shutdown at the time defined.

This aproach instead of calculating when to shutdown, checks every minute if the system is ready to shutdown, checks including

  • Is clock in sync
  • Is there a scheduled time to shutdown
  • Is time to shutdown
  • Is system in always mode (I think it would not be expected / allowed to shutdown the system while in contest / event mode, right?)

@DT3264 DT3264 force-pushed the pr206 branch 3 times, most recently from 9e1f3d2 to 1eae9ae Compare September 4, 2023 06:44
@DT3264
Copy link
Collaborator Author

DT3264 commented Sep 4, 2023

@equetzal I've already tested this aproach and it seems to work as expected, I'l set this PR as a review-ready though I'll set it as draft again in case you can see something I cannot see

@DT3264 DT3264 marked this pull request as ready for review September 4, 2023 06:49
@DT3264 DT3264 mentioned this pull request Sep 4, 2023
This commit adds support for a new global directive "ShutdownTime", like ContestTimes or ConfigExpirationTime, that schedules a shutdown at the time defined.

This aproach instead of calculating when to shutdown, checks every minute if the system is ready to shutdown, checks including

- Is clock in sync
- Is there a scheduled time to shutdown
- Is time to shutdown
- Is system in always mode (I think it would not be expected / allowed to shutdown the system while in contest / event mode, right?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant