Improving ipman service #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DT3264
force-pushed
the
pr207
branch
2 times, most recently
from
2da3080 to
3a47f35
Compare
This was referenced Oct 9, 2023
Updates IPMan to - ping the directives server (if available) since sometimes the gateway might be blocked, it should not affect if the directives server is empty since a ping with an empty command just throws an error which is handled on the if
This PR improves the IPMan service to be more rock solid (restar automatically if failed and to not be re-runed if it was executed succesfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving ipman service
This PR improves the IPMan service to be more rock solid (restar automatically if failed and to not be re-runed if it was executed succesfully.
Stack created with Sapling. Best reviewed with ReviewStack.