-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update smoltcp to 0.12.0
and embassy-net to 0.5.0
#2849
base: main
Are you sure you want to change the base?
Update smoltcp to 0.12.0
and embassy-net to 0.5.0
#2849
Conversation
Lets just get rid of |
9a6afcf
to
6faa164
Compare
I'm wondering if this needs a migration guide. The update for |
6faa164
to
e707cc5
Compare
`smoltcp-nal`, a core dependency on which this example depends on doesn't receive the desired amount of maintainability needed to keep up to date with new dependencies releases.
e707cc5
to
5774b4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This provides an update for
smoltcp@0.11.0
->smoltcp@0.12.0
and bumpsembassy-net
to0.5.0
for the examples.I've only updated the API surface and examples so it builds; perhaps new APIs introduced by
smoltcp@0.12.0
would be worth an internal driver refactor for optimization.Closes #2662
TODO:
embassy_net_driver::RxToken::consume()
andsmoltcp::phy::RxToken::consume()
embassy-rs/embassy#3670esp-hal/esp-wifi/src/wifi/mod.rs
Lines 2684 to 2690 in 9a6afcf
wifi_dhcp_smoltcp_nal.rs
Testing
CI needs to pass, and runtime needs to be tested.