Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoltcp to 0.12.0 and embassy-net to 0.5.0 #2849

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AnthonyGrondin
Copy link
Contributor

@AnthonyGrondin AnthonyGrondin commented Dec 19, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This provides an update for smoltcp@0.11.0 -> smoltcp@0.12.0 and bumps embassy-net to 0.5.0 for the examples.
I've only updated the API surface and examples so it builds; perhaps new APIs introduced by smoltcp@0.12.0 would be worth an internal driver refactor for optimization.
Closes #2662

TODO:

Testing

CI needs to pass, and runtime needs to be tested.

esp-wifi/src/wifi/mod.rs Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 20, 2024

Lets just get rid of wifi_dhcp_smoltcp_nal.rs - we plan to reorganize / rewrite examples and the example isn't that useful

@AnthonyGrondin
Copy link
Contributor Author

I'm wondering if this needs a migration guide. The update for esp-wifi is completely transparent, and the examples only really changed to demonstrate how to use the new embassy-net@0.5.0 release. We don't hardly depend on embassy-net for esp-wifi.

@AnthonyGrondin AnthonyGrondin force-pushed the chore/update-smoltcp-0-12-0 branch from 6faa164 to e707cc5 Compare December 21, 2024 06:44
@AnthonyGrondin AnthonyGrondin marked this pull request as ready for review December 21, 2024 06:59
examples/Cargo.toml Outdated Show resolved Hide resolved
`smoltcp-nal`, a core dependency on which this example depends on doesn't receive the desired amount of maintainability needed to keep up to date with new dependencies releases.
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to smoltcp 0.12.0
3 participants