Issue 1993 + Issue 2057 (Benchmarks provisioning) #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmesamster
changed the title
itsmesamster
force-pushed
the
issue_1993
branch
10 times, most recently
from
d944ab7 to
36d1a51
Compare
itsmesamster
force-pushed
the
issue_1993
branch
6 times, most recently
from
8fe2985 to
82af496
Compare
itsmesamster
force-pushed
the
issue_1993
branch
from
b239d43 to
9b3e521
Compare
DmitryAstafyev
requested changes
Aug 28, 2024
application/apps/rustcore/ts-bindings/spec/session.stream.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.search.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.search.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.benchmark.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.benchmark.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.indexes.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.indexes.spec.ts
Outdated
Show resolved
Hide resolved
application/apps/rustcore/ts-bindings/spec/session.observe.spec.ts
Outdated
Show resolved
Hide resolved
itsmesamster
force-pushed
the
issue_1993
branch
3 times, most recently
from
8a5d44d to
2a9d552
Compare
DmitryAstafyev
approved these changes
Sep 9, 2024
|
@itsmesamster great job Sameer! Let's also consider new build CLI sys to run benchmarks and let it go |
itsmesamster
force-pushed
the
issue_1993
branch
from
2a9d552 to
f107582
Compare
|
@AmmarAbouZor in the scope of this PR we would need an additional build CLI command. Right now we have the command Shell.sh "#{Paths::JASMINE} spec/build/spec/session.#{spec}.spec.js"To something like this (with CLI): cargo chipmunk test bindings --custom=full_path/spec/build/spec/benchmarks.spec.jsCould you please take care of it as soon as you will have some time? |
|
Hi @DmitryAstafyev @itsmesamster
I've increased the version of the tool and added the change to the CHANGELOG as well. |
AmmarAbouZor
force-pushed
the
issue_1993
branch
from
ec73b76 to
84a6340
Compare
itsmesamster
force-pushed
the
issue_1993
branch
2 times, most recently
from
e0509db to
9341f6b
Compare
* Users can set custom wrapper tests via CLI arguments. * Custom specs is prepared to be used with different jobs when needed * Refactor: Create struct `JobConfigs` to represent jobs state configs * Fix: Rename `child` to `cmd`. * Increase tool version and add changes to CHANGELOG
* Add missing build rust core step with linting and testing jobs for binding, wrapper and app targets * Improve code comments to clarify the complex logic code in that position
itsmesamster
force-pushed
the
issue_1993
branch
from
11df810 to
3852c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.