Check prepaid balance #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # contracts/EthStorageContract.sol # scripts/deploy.js
syntrust
reviewed
Sep 6, 2024
| @@ -30,6 +30,7 @@ contract EthStorageContract is StorageContract, Decoder { | |||
| address _treasury, | |||
| address _owner | |||
| ) public payable initializer { | |||
| require(msg.value >= prepaidAmount, "prepaid amount is not enough"); | |||
There was a problem hiding this comment.
prepaidAmount is not set value yet, is it _prepaidAmount that we should check?
Maybe a better place is inside __init_storage in StorageContract?
| const ethStorageProxy = await EthStorageUpgradeableProxy.deploy(impl, ownerAddress, data, { gasPrice: gasPrice }); | ||
| const ethStorageProxy = await EthStorageUpgradeableProxy.deploy(impl, ownerAddress, data, { | ||
| gasPrice: gasPrice, | ||
| value: prepaidAmount |
There was a problem hiding this comment.
I'm not sure if we allocate 3145 ETH when deploying the contract. Do we?
| // const ethStorage = StorageContract.attach(ethStorageProxy.address); | ||
| // const tx = await ethStorage.sendValue({ value: hre.ethers.utils.parseEther("0.5") }); | ||
| // await tx.wait(); | ||
| // console.log("balance of " + ethStorageProxy.address, await hre.ethers.provider.getBalance(ethStorageProxy.address)); | ||
|
|
There was a problem hiding this comment.
Changes made to deploy.js may need to apply to deployL2.js.
ping-ke
reviewed
Sep 23, 2024
| @@ -52,16 +53,20 @@ async function deployContract() { | |||
|
|
|||
| const data = implContract.interface.encodeFunctionData("initialize", [ | |||
| 4718592000, // minimumDiff 5 * 3 * 3600 * 1024 * 1024 / 12 = 4718592000 for 5 replicas that can have 1M IOs in one epoch | |||
| 3145728000000000000000n, // prepaidAmount - 50% * 2^39 / 131072 * 1500000Gwei, it also means 3145 ETH for half of the shard | |||
| prepaidAmount, // prepaidAmount - 50% * 2^39 / 131072 * 1500000Gwei, it also means 3145 ETH for half of the shard | |||
There was a problem hiding this comment.
remove comments?
no need "// prepaidAmount - 50% ..."
|
I think we can close this PR and related issue since we are implementing this |
|
Close as the issue resolved by #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify whether enough balance has been paid when initializing the contract. #40