Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the coding style according to OPStack's guide #95

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Conversation

qzhodl
Copy link
Contributor

@qzhodl qzhodl commented Jun 21, 2024

The coding style guide is here

The changes are mainly for:

  • Natspec comments style for all the files that we write
  • Naming conventions for constants, immutables, and parameters
  • Error handling messages
  • Restructuring the file folders

The PR has passed the UI test.

@qzhodl qzhodl requested review from iteyelmp and syntrust June 21, 2024 04:51
@qzhodl qzhodl requested a review from iteyelmp June 21, 2024 08:43
contracts/StorageContract.sol Outdated Show resolved Hide resolved
contracts/DecentralizedKV.sol Outdated Show resolved Hide resolved
contracts/EthStorageContract2.sol Outdated Show resolved Hide resolved
contracts/EthStorageContract2.sol Outdated Show resolved Hide resolved
contracts/EthStorageContract2.sol Outdated Show resolved Hide resolved
contracts/EthStorageContractL2.sol Outdated Show resolved Hide resolved
contracts/EthStorageContractL2.sol Outdated Show resolved Hide resolved
contracts/libraries/RandaoLib.sol Show resolved Hide resolved
contracts/DecentralizedKV.sol Show resolved Hide resolved
contracts/DecentralizedKV.sol Outdated Show resolved Hide resolved
contracts/EthStorageContract.sol Outdated Show resolved Hide resolved
@qzhodl qzhodl requested review from iteyelmp and syntrust June 21, 2024 10:52
@qzhodl qzhodl requested a review from syntrust June 24, 2024 03:14
@qzhodl qzhodl merged commit 6e1def2 into main Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants