Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Automatic Build and Push Actions #670

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mandulaj
Copy link
Contributor

@mandulaj mandulaj commented Feb 9, 2024

The workflows have been rewritten to be slightly more modular.

There is still the test build action in docker_build.yaml which builds Kalibr in Ubuntu 16,18 and 20 and is triggered by any PR just like the old Build Actions.

There is also a new push action in docker_push.yaml which builds and pushes the images to a registry. Currently, it builds both an amd64 as well as arm64 versions. This can easily be configured.

At the moment it is pushed to my personal Docker Hub however, this can also easily be changed by modifying the DOCKER_HUB_REPOSITORY repository variable. Probably would be nice to have an ethz-asl or Kalibr Docker hub or use the GitHub Container Registry.

The Push is only triggered by making a Release. I have noticed that Kalibr doesn't make releases, so this can easily be changed by triggering on a push to master.

All in all, this makes using Kalibr very simple without the need to compile anything:
docker run -it -v pwd:/pwd mandulaj/kalibr:20.04

Or one can easily base their Dockerfile environments like this:

FROM mandulaj/kalibr:20.04

RUN ....

This is for sure work in progress, however, would be nice to integrate it.

We can for sure discuss modifying the final Registry location and form factor or adding some kind of Image versioning (although Kalibr doesn't really follow any versioning scheme).

@mandulaj
Copy link
Contributor Author

mandulaj commented May 8, 2024

Any update on this? I had quite a few requests about why my personal docker hub mandulaj/kalibr:20.04 is not linked in this repository.....

@goldbattle
Copy link
Collaborator

Sorry, have not had the bandwidth to look at. I think the changes are good and like the matrix use in the yamls. Next month I should be a bit more free so plan to take a look and also figure out how to get things setup officially. I really appreciate the effort.

@mandulaj
Copy link
Contributor Author

If you are very busy @goldbattle, let me know if you need any help with setting things up 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants