Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use todo instead of unimplemented #1723

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Use todo instead of unimplemented #1723

merged 1 commit into from
Sep 14, 2023

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Sep 10, 2023

The difference is one of intent, and the actual panic message.
See the docs why todo is more appropriate:
https://doc.rust-lang.org/stable/std/macro.todo.html

[no important files changed]

closes #1598

@senekor senekor mentioned this pull request Sep 10, 2023
Closed
@senekor
Copy link
Contributor Author

senekor commented Sep 10, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@senekor senekor mentioned this pull request Sep 10, 2023
Merged
@senekor senekor marked this pull request as ready for review September 10, 2023 20:06
This was referenced Sep 10, 2023
Merged
Merged
Merged
This was referenced Sep 11, 2023
Merged
Merged
@senekor senekor mentioned this pull request Sep 11, 2023
Merged
@senekor senekor force-pushed the unimpl-todo branch 3 times, most recently from 654a972 to d94f686 Compare September 12, 2023 18:47
This was referenced Sep 12, 2023
Merged
Merged
Base automatically changed from auto-sync to main September 13, 2023 16:54
@senekor
Use todo!() instead of unimplemented!()
6d4fa9f 
The difference is one of intent, and the actual panic message.
See the docs why todo is more appropriate:
https://doc.rust-lang.org/stable/std/macro.todo.html

[no important files changed]

closes #1598
ErikSchierboom
ErikSchierboom approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great

@senekor senekor merged commit da5429a into main Sep 14, 2023
@senekor senekor deleted the unimpl-todo branch September 14, 2023 06:35
This was referenced Sep 14, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Nitpick) Use todo! instead of unimplemented!.
2 participants
@senekor @ErikSchierboom