Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test order of low-power-embedded-game #1725

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Improve test order of low-power-embedded-game #1725

merged 1 commit into from
Sep 15, 2023

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Sep 10, 2023

Source:
#1583

Students may think they have to work with values
instead of their position.
This confusion can easily be avoided if the first test uses strings.

@senekor senekor mentioned this pull request Sep 10, 2023
Closed
@senekor senekor changed the base branch from circ-buffer-example to unimpl-todo September 10, 2023 20:03
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from e8b3320 to 42aa563 Compare September 10, 2023 20:03
@senekor
Copy link
Contributor Author

senekor commented Sep 10, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@senekor senekor mentioned this pull request Sep 10, 2023
Merged
@senekor senekor marked this pull request as ready for review September 10, 2023 20:07
@senekor senekor changed the base branch from unimpl-todo to no-test-prefix September 11, 2023 18:28
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from 42aa563 to a4ef8c6 Compare September 11, 2023 18:28
This was referenced Sep 11, 2023
Merged
Merged
Merged
This was referenced Sep 11, 2023
Merged
Merged
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from a4ef8c6 to cfda19c Compare September 11, 2023 20:21
@senekor senekor mentioned this pull request Sep 11, 2023
Merged
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from cfda19c to 3a7a1ac Compare September 11, 2023 21:08
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from 3a7a1ac to 5c44568 Compare September 12, 2023 18:10
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from 5c44568 to 08c5a3d Compare September 12, 2023 18:16
@senekor senekor mentioned this pull request Sep 12, 2023
Merged
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from 08c5a3d to 5524e0d Compare September 12, 2023 18:49
@senekor senekor mentioned this pull request Sep 13, 2023
Merged
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from 5524e0d to 94c466e Compare September 13, 2023 16:57
Base automatically changed from no-test-prefix to main September 14, 2023 10:17
@senekor
Improve test order of low-power-embedded-game
f018277 
Source:
#1583

Students may think they have to work with values
instead of their position.
This confusion can easily be avoided if the first test uses strings.
@senekor senekor force-pushed the low-pow-embbd-game-test-order branch from 94c466e to f018277 Compare September 14, 2023 14:51
@senekor senekor mentioned this pull request Sep 14, 2023
Merged
@senekor senekor merged commit 212ee0a into main Sep 15, 2023
@senekor senekor deleted the low-pow-embbd-game-test-order branch September 15, 2023 09:15
This was referenced Sep 16, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senekor @ErikSchierboom