[FEATURE] Enable link from cart to detail view #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintisch
force-pushed
the
feature/167/enable-detail-view-link-from-cart
branch
from
5b701e6
to
57df458
Compare
|
Tests are failing due to not existing methods in EXT:cart because they do not exist in its main branch. |
rintisch
force-pushed
the
feature/167/enable-detail-view-link-from-cart
branch
from
57df458
to
e079a8b
Compare
|
@extcode I made a update which was necessary after migrating the switchableControllerActions. I have still not tested it with the landing page approach but the other scenarios are working. |
This is a needed adaption to make it possible that a product detail view can be linked from the product list of the cart. Fixes: extcode#167
After the migration of switchableControllerActions the pluginName can differ which needs to be considered.
Link from the cart product list to products which are put into the cart from a landing page (doktype `183`) via the plugin `cartproducts_singleproduct` are no correctly resolved.
rintisch
force-pushed
the
feature/167/enable-detail-view-link-from-cart
branch
from
e079a8b
to
0f6750d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a needed adaption to make it possible
that a product detail view can be linked from
the product list of the cart.
Fixes: #167