[Lexical] Attempt to fix after approval workflow

[Sahejkm]

• Fix the label-on-approval workflow #6136 adds pull_request_target action but it doesn't get triggered on approve so its not helpful right now to use as is, hence could be removed to avoid confusions.

using my fine grain access PAT to trigger the workflow for add label

• it only has read/write access to PR and
• read access to content

Test Plan

• tested in testing... #6168

TODO

• will replace my PAT with lexical-bot PAT once setup is done

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2024 2:44pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2024 2:44pm

[Sahejkm]

test review

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/lexical/dist/Lexical.js	23.93 KB (0%)	479 ms (0%)	26 ms (+0.14% 🔺)	505 ms
packages/lexical-rich-text/dist/LexicalRichText.js	34.59 KB (0%)	692 ms (0%)	84 ms (-7.29% 🔽)	776 ms
packages/lexical-plain-text/dist/LexicalPlainText.js	34.59 KB (0%)	692 ms (0%)	158 ms (+81.6% 🔺)	850 ms

[necolas]

Why did leaving a review (not approval) add the extended-tests label?

[zpao]

You linked to another repo and they're using the first-party actions/labeler action. I'd consider doing the same. It has some good notes on permissions which are helpful. https://github.com/actions/labeler?tab=readme-ov-file#permissions

[Sahejkm]

Why did leaving a review (not approval) add the extended-tests label?

That was done to test the changes only in draft mode, after publishing it's not doing this , I removed the label after testing was done.

[Sahejkm]

I am thinking of exploring the custom GitHub bot for fixing the problem we are facing with permissions as it would have the required permissions in this case as we want to trigger the add label event on approval and pull_request_target doesn't help us with this.