Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lexical] Attempt to fix after approval workflow #6153

Merged
merged 4 commits into from
May 23, 2024
Merged

[Lexical] Attempt to fix after approval workflow #6153

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43d2104
Attempt to fix after approval workflow
Sahejkm May 21, 2024
f57776d
.
Sahejkm May 21, 2024
0a05679
.
Sahejkm May 23, 2024
ad3e940
remove e2e tests job as now we are using pat token to add label , git…
Sahejkm May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/after-approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ name: After Approval
on:
pull_request_review:
types: [submitted]
pull_request_target:
Sahejkm marked this conversation as resolved.
Show resolved Hide resolved
types: [review_requested, opened, reopened, synchronize]
branches:
- 'main'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -17,16 +13,14 @@ jobs:
if: github.event.review.state == 'approved' && !contains(github.event.pull_request.labels.*.name, 'extended-tests')
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- name: Add label for extended tests
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_TOKEN: ${{ secrets.ADD_LABEL_PAT }}
GH_REPO: ${{ github.repository }}
NUMBER: ${{ github.event.pull_request.number }}
run: |
echo "Adding label 'extended-tests' to PR $NUMBER"
gh pr edit "$NUMBER" --add-label "extended-tests" || (echo "Failed to add label" && exit 1)
e2e-tests:
needs: label-pr
uses: ./.github/workflows/call-e2e-all-tests.yml
Sahejkm marked this conversation as resolved.
Show resolved Hide resolved
Loading