Add support for parquet_writer_version session property
#11151
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Oct 2, 2024
Yuhta
reviewed
Oct 3, 2024
yingsu00
reviewed
Nov 7, 2024
svm1
force-pushed
the
parq_2
branch
2 times, most recently
from
40a6c6c to
4982e1f
Compare
|
@yingsu00 @majetideepak Thank you for reviewing - made all necessary changes, please take a look! |
| @@ -921,6 +921,21 @@ std::optional<std::string> getTimestampTimeZone( | |||
| return std::nullopt; | |||
| } | |||
|
|
|||
| parquet::WriterOptions::DataPageVersion getParquetDataPageVersion( | |||
There was a problem hiding this comment.
The changes in this file have to move to the parquet::WriterOptions inside parquet/writer/Writer.h
| // Set parquet datapage version and write data - then read to ensure the | ||
| // property took effect. | ||
| const auto testDataPageVersion = | ||
| [&](facebook::velox::parquet::WriterOptions::DataPageVersion |
There was a problem hiding this comment.
Can remove facebook::velox:: here and at other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Presto session property
parquet_writer_version, which is currently ignored by Velox, to toggle the parquet writer datapage version (V1 or V2). The value can be set as a session property or can be provided in the Hive config. Defaults to V2.