Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abfs): Dangling-gsl error in AbfsFileSystemTest.cpp #12054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(abfs): Dangling-gsl error in AbfsFileSystemTest.cpp #12054

wants to merge 1 commit into from
+4 −5

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Jan 10, 2025 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@majetideepak majetideepak requested a review from kgpai January 10, 2025 02:07
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit ab16262
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/678080d1b8b014000804152a

@majetideepak majetideepak changed the title fix(abfs): dangling-gsl error in AbfsFileSystemTest.cpp fix(abfs): Dangling-gsl error in AbfsFileSystemTest.cpp Jan 10, 2025
@majetideepak
Copy link
Collaborator Author

CC: @zhli1142015

zhli1142015
zhli1142015 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@zhli1142015 zhli1142015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhli1142015 zhli1142015 zhli1142015 approved these changes

@kgpai kgpai kgpai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majetideepak @kgpai @zhli1142015 @facebook-github-bot