Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abfs): Dangling-gsl error in AbfsFileSystemTest.cpp #12054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(abfs): Dangling-gsl error in AbfsFileSystemTest.cpp #12054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions velox/connectors/hive/storage_adapters/abfs/tests/AbfsFileSystemTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,8 @@ void readData(ReadFile* readFile) {
ASSERT_EQ(readFile->pread(10 + kOneMB, 5, &buffer1), "ddddd");
char buffer2[10];
ASSERT_EQ(readFile->pread(0, 10, &buffer2), "aaaaabbbbb");
auto buffer3 = new char[kOneMB];
char buffer3[kOneMB];
ASSERT_EQ(readFile->pread(10, kOneMB, buffer3), std::string(kOneMB, 'c'));
delete[] buffer3;
ASSERT_EQ(readFile->size(), 15 + kOneMB);
char buffer4[10];
const std::string_view arf = readFile->pread(5, 10, &buffer4);
Expand Down Expand Up @@ -286,8 +285,8 @@ TEST_F(AbfsFileSystemTest, registerAbfsFileSink) {
auto sink = dwio::common::FileSink::create(
path, {.connectorProperties = hiveConfig});
auto writeFileSink = dynamic_cast<dwio::common::WriteFileSink*>(sink.get());
auto writeFile =
dynamic_cast<AbfsWriteFile*>(writeFileSink->toWriteFile().get());
ASSERT_TRUE(writeFile != nullptr);
auto writeFile = writeFileSink->toWriteFile();
auto abfsWriteFile = dynamic_cast<AbfsWriteFile*>(writeFile.get());
ASSERT_TRUE(abfsWriteFile != nullptr);
}
}
Loading