fix: Make TPCH dbgen text buffer size consistent with Presto Java

[minhancao]

Changed text buffer size to be 300 MB for Velox's dbgen to match with Java Presto TPCH dbgen's text buffer size. The text buffer size is used in randomly generating offset and length to grab a chunk from the overall text for each row. This fixed the difference in the comment column for the tables in TPCH.

Java:
https://github.com/trinodb/tpch/blob/master/src/main/java/io/trino/tpch/TextPool.java#L35

private static final int DEFAULT_TEXT_POOL_SIZE = 300 * 1024 * 1024;

C++:
https://github.com/facebookincubator/velox/blob/main/velox/tpch/gen/DBGenIterator.cpp#L40

load_dists(
        10 * 1024 * 1024, &dbgenCtx); // 10 MB buffer size for text generation.

Resolves: prestodb/presto#24011

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	aee5149
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/6794274a005b200008017db2

[aditi-pandit]

@minhancao : Please fix the PR title fix: Make TPCH dbgen text buffer size consistent with Presto Java

[aditi-pandit]

Thanks @minhancao

[aditi-pandit]

@minhancao : Please can you fix the test

[ RUN      ] TpchConnectorTest.simple
/__w/velox/velox/velox/vector/tests/utils/VectorTestBase.cpp:151: Failure
Value of: expected->equalValueAt(actual.get(), i, i)
  Actual: false
Expected: true
at 0: expected {0, ALGERIA, 0, furiously regular requests. platelets affix furious}, but got {0, ALGERIA, 0,  haggle. carefully final deposits detect slyly agai}
[  FAILED  ] TpchConnectorTest.simple (1422 ms)

[amitkdutta]

Just tested with java and c++, checksum on o_comment matches with this change.

Java:
presto:de> select checksum(o_comment) from tpch.sf1.orders;
          _col0          
-------------------------
 04 60 df 1a 45 10 06 84 
(1 row)


C++:
presto:de> select checksum(o_comment) from tpch.sf1.orders;
          _col0          
-------------------------
 04 60 df 1a 45 10 06 84

[minhancao]

@aditi-pandit Fixed the test by updating the expected vector for n_comment column.

[aditi-pandit]

Thanks @minhancao

[amitkdutta]

Looks good.

[kgpai]

@minhancao Can you rebase against latest ? Not sure why the fuzzer build jobs are failing.

[minhancao]

@kgpai Rebased to latest main branch

[facebook-github-bot]

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@xiaoxmeng merged this pull request in dea4758.

[conbench-facebook]

Conbench analyzed the 0 benchmark runs that triggered this notification.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.