Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blip2 loss under torchmultimodal/modules/losses #485

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pikapecan
Copy link

Summary: as title

Differential Revision: D50148648

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: 7ebdb5ee0698217d0db671075f25eff4f9de6334
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: 5c8444535286afa6be2c366a75da185ad45513ef
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: 65d712b7c05a23eec5d8e4a37486afc33024f145
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: c5f0525e89b1c8faaab484d122736a8783f3af92
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: 24c2b5f635e31ea5efba74a332f365506adc3820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: 6d2d2de339a413c6f0ef152328d67249a8f7be84
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

pikapecan pushed a commit to pikapecan/multimodal that referenced this pull request Oct 11, 2023
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: be7ba4951b32c8d6cc0363f042a5a3ae725411d3
pengchen18 and others added 4 commits October 11, 2023 15:36
Differential Revision: D50137871

fbshipit-source-id: 6f3a89bc5424498e66055c02cc6f758d68220d7a
Differential Revision: D50145316

fbshipit-source-id: 98bcbbd352c0a69a68162d744b1f792b428ff7f0
Differential Revision: D50145708

fbshipit-source-id: 6250373045f857fae426cb782031e18ada335d8f
…#485)

Summary:
Pull Request resolved: facebookresearch#485

as title

Differential Revision: D50148648

fbshipit-source-id: 04f3fbb096c8dde167c792f5496bd87cd295c8c0
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (b8226b9) 72.58% compared to head (5e21bbf) 73.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   72.58%   73.92%   +1.33%     
==========================================
  Files         195      205      +10     
  Lines       13248    14035     +787     
==========================================
+ Hits         9616    10375     +759     
- Misses       3632     3660      +28     
Files Coverage Δ
tests/models/blip2/test_blip2.py 100.00% <100.00%> (ø)
tests/models/blip2/test_qformer_layers.py 100.00% <100.00%> (ø)
tests/models/blip2/test_qformer_model.py 100.00% <100.00%> (ø)
tests/models/blip2/test_qformer_utils.py 100.00% <100.00%> (ø)
torchmultimodal/models/blip2/blip2.py 100.00% <100.00%> (ø)
torchmultimodal/models/blip2/qformer_model.py 100.00% <100.00%> (ø)
torchmultimodal/models/blip2/qformer_utils.py 100.00% <100.00%> (ø)
torchmultimodal/modules/losses/blip2_losses.py 100.00% <100.00%> (ø)
torchmultimodal/models/blip2/qformer_layers.py 96.63% <96.63%> (ø)
tests/modules/losses/test_blip2_loss.py 72.58% <72.58%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50148648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants