docs: add docs and some inplace fixes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Aug 1, 2024
| pub use stdio::*; | ||
| pub use opentelemetry::OpentelemetryLog; | ||
| #[cfg(feature = "rolling_file")] | ||
| pub use rolling_file::RollingFile; |
There was a problem hiding this comment.
Lift the appender to the same level for docs.
There was a problem hiding this comment.
But we can't hide rolling_file::RollingFile anyway?
tisonkun
commented
Aug 1, 2024
Comment on lines
+78
to
84
| pub fn append(mut self, append: impl Append) -> Dispatch<true, true> { | ||
| self.appends.push(Box::new(append)); | ||
|
|
||
| Dispatch { | ||
| filters: self.filters, | ||
| appends: vec![Box::new(append)], | ||
| appends: self.appends, | ||
| layout: self.layout, |
There was a problem hiding this comment.
Fix a bug that previously append override the preconfigured appends.
tisonkun
commented
Aug 1, 2024
| #[derive(Debug)] | ||
| pub struct Logger { | ||
| pub struct Logger<const APPEND: bool = true> { |
There was a problem hiding this comment.
Hide apply until at least one append are configured.
Closed
This was referenced Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.