Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing Brazilian portuguese translations + refactor language files for clarity, consistency, and grammatical accuracy #14641

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

deusmar
Copy link
Contributor

@deusmar deusmar commented Oct 27, 2024

  • Simplification and Reduction of Redundancy;
  • Adjustment for Grammatical Agreement and Textual Cohesion
  • Standardization of Terms
  • Adjustment of Verb-Preposition Usage
  • Adaptation to User Expectations and Digital Context

…istency, and grammatical accuracy

- Simplified text and removed redundant messages to enhance conciseness
- Adjusted grammatical agreement for verb-object clarity (e.g., "Recolher todos")
- Standardized terminology (e.g., replaced "Sair" with "Logout") for cohesion across UI
- Refined verb-preposition usage for more precise expressions (e.g., "para esquerda")
- Removed unnecessary alerts and messages to improve contextual appropriateness
@deusmar deusmar requested a review from saade as a code owner October 27, 2024 18:06
@deusmar deusmar changed the title Adds missing translations + refactor language files for clarity, consistency, and grammatical accuracy Adds missing Brazilian portuguese translations + refactor language files for clarity, consistency, and grammatical accuracy Oct 27, 2024
@danharrin danharrin added this to the v3 milestone Oct 28, 2024
Copy link
Contributor

@leandrocfe leandrocfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deusmar, thank you for the PR. Could you check the comments please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filament uses Login and Logout even in Portuguese. While these terms aren't translated, they are widely recognized and commonly used in Portuguese to describe these actions across many applications.
I prefer it in English, but I'm open to translating it. If we do translate, though, we should also apply the same approach to the word Login.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually in pt_PT, and no changes are needed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned some changes, such as "Adicionar em" to "Adicionar a", "Recolher todos" to "Recolher tudo", etc. Although both seem grammatically correct, I think if we decide to make these adjustments, we should apply them consistently across other areas, such as in the Repeater component. For instance, Repeater uses labels like Builder, and it would feel inconsistent if we update labels in Builder but not in Repeater..

@danharrin
Copy link
Member

@deusmar please check @leandrocfe's review, we cannot merge this without the comments being addressed

@deusmar
Copy link
Contributor Author

deusmar commented Nov 11, 2024

Sorry guys, let me check them. Thanks for the heads-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants