Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sprite artifacts 2 #1044

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

nelson137
Copy link
Contributor

Follow-up to #1041.

Changes

  • Fix the rest of the sprite artifacts in ship_decorations

Things Worth Mentioning

  • Changed levels 3 & 8 to use YAML flow style so that I could find tiles by position (e.g. by searching for pos: [13, 10]:

    Before:

    tiles:
    - pos:
      - 1
      - 2
      idx: 3
      collision: Solid

    After:

    tiles:
    - { pos: [1, 2], idx: 3, collision: Solid }
  • Add script to get the layer names in any level files that use specific tile indexes of a tilemap:

    # Find all crow's nests (indexes 30-32) from ship_decorations
    $ ./scripts/find-atlas-tiles.sh ship_decorations.atlas.yaml '[30,31,32]'
    
    ./assets/map/levels/level_3.map.yaml
    - foreground
    
    ./assets/map/levels/level_8.map.yaml
    - foreground
    
    # This tells us levels 3 and 8 have crow's nests in their "foreground" layer
  • Fix git attributes for text files in assets/ & old_assets/ which shouldn't be treated as binary (yaml, txt, ftl)

@MaxCWhitehead
Copy link
Collaborator

Sorry fixing this up is so painful - need to get the level editor back in. Thanks!

@MaxCWhitehead MaxCWhitehead added this pull request to the merge queue Nov 22, 2024
Merged via the queue into fishfolk:main with commit 0f51b9f Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants