-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Translation Tag #36
base: master
Are you sure you want to change the base?
Conversation
Started test build 43424 |
@@ -36,4 +36,5 @@ to the client, you can work with your files even when you are not online!</p> | |||
<release date="2019-07-22" version="2.5.3"/> | |||
</releases> | |||
<content_rating type="oars-1.1"/> | |||
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the translation tag is not used for this. It's used to compute if your currently used language is available on that said app. If you want to link to where the user could contribute translations, you should use the url tag instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the XDG Appstream specification, that's not the case, unless Flathub works differently:
translate
URLs of this type should point to a webpage where users can submit or modify translations of the upstream project.
Typically this should be a link to the project page in Weblate, Transifex or Zanata, but could also be a link to an upstream-hosted wiki page describing how to send translations upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're looking at the url of type translate, not the translation tag here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that, too. I'm not sure what the difference is, considering:
<translation/>
#The
<translation/>
tag is an optional tag which can be added to specify the translation domain used for this software component. It may be used by the AppStream distro metadata generator to determine the translation status of the respective software (e.g. which languages the software is translated into and how complete the translations are).
I also used this as a reference for the <languages />
and <lang />
tags in my other pull request (strictly speaking it's for a different metadata file, though the file still validates with appstreamcli
).
Build 43424 successful
|
Sure, why not have both.
Started test build 43433 |
Build 43433 failed |
Started test build 43436 |
Build 43436 successful
|
This is a feature of the AppStream specification, and it wouldn't hurt to add it.