Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translation Tag #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Translation Tag #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fda2d2
Add translation tag
elsiehupp Mar 30, 2021
f635c89
Added <url type="translation">, too
elsiehupp Mar 30, 2021
3d1c18a
"translate" instead of "translation"
elsiehupp Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions com.nextcloud.desktopclient.nextcloud.metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ to the client, you can work with your files even when you are not online!</p>
</screenshot>
</screenshots>
<url type="homepage">https://nextcloud.com</url>
<url type="translate">https://www.transifex.com/nextcloud/nextcloud/</url>
<releases>
<release version="3.1.3" date="2021-02-19"/>
<release version="3.1.2" date="2021-02-05"/>
Expand All @@ -36,4 +37,5 @@ to the client, you can work with your files even when you are not online!</p>
<release date="2019-07-22" version="2.5.3"/>
</releases>
<content_rating type="oars-1.1"/>
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translation tag is not used for this. It's used to compute if your currently used language is available on that said app. If you want to link to where the user could contribute translations, you should use the url tag instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the XDG Appstream specification, that's not the case, unless Flathub works differently:

translate

URLs of this type should point to a webpage where users can submit or modify translations of the upstream project.

Typically this should be a link to the project page in Weblate, Transifex or Zanata, but could also be a link to an upstream-hosted wiki page describing how to send translations upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're looking at the url of type translate, not the translation tag here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, too. I'm not sure what the difference is, considering:

<translation/> #

The <translation/> tag is an optional tag which can be added to specify the translation domain used for this software component. It may be used by the AppStream distro metadata generator to determine the translation status of the respective software (e.g. which languages the software is translated into and how complete the translations are).

I also used this as a reference for the <languages /> and <lang /> tags in my other pull request (strictly speaking it's for a different metadata file, though the file still validates with appstreamcli).

</component>