Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sokol_gfx.h: allow multisampled images as resource bindings #1155

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

floooh
Copy link
Owner

@floooh floooh commented Nov 17, 2024

Allows to fetch samples in shader from multisampled textures (for instance to allow custom-resolve render passes).

Not supported on WebGL2/GLES3 because no of missing support for multisampled texture objects, and also not on macOS because it just doesn't seem to work (even though the required function exist, but only in gl3ext.h, not in gl3.h).

Related ticket: #1142

  • changelog entry
  • integrate new custom resolve sample into sample webpage
  • update docs (sg_features.msaa_image_bindings)
  • add a coverage visualization to the custom resolve sample
  • test:
    • macOS + Metal
    • macOS + GL
      • crash: Assertion failed: (glGetError() == 0), function _sg_gl_cache_bind_texture_sampler, file sokol_gfx.h, line 8195. simply disable msaa texture code path on macOS+GL, not worth the hassle
    • iOS + Metal
    • iOS + GLES3 (not supported)
    • Windows + D3D11
    • Windows + GL
    • Linux + GL
    • WebGL2 (not supported)
    • WebGPU
    • Android (not supported)

@floooh floooh merged commit 30a1eb0 into master Nov 19, 2024
70 checks passed
@floooh floooh deleted the bind_msaa_images branch November 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant