fix: do not import non-query based queries

frappe · Nov 4, 2023 · f94eb9a · f94eb9a
1 parent dca18f3
commit f94eb9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/insights/insights/doctype/insights_data_source/sources/query_store.py b/insights/insights/doctype/insights_data_source/sources/query_store.py
@@ -23,6 +23,8 @@ def sync_tables(self, connection, tables=None, force=False):
         self.connection = connection
         to_sync = self.get_stored_queries() if tables is None else tables
         for docname in to_sync:
+            if not frappe.db.exists("Insights Query", docname):
+                continue
             doc = frappe.get_doc("Insights Query", docname)
             # fetch results internally imports them into the db
             # also updates the insights table

diff --git a/insights/insights/doctype/insights_query/insights_legacy_query.py b/insights/insights/doctype/insights_query/insights_legacy_query.py
@@ -335,7 +335,9 @@ def get_selected_tables(self):
     def before_fetch(self):
         if self.doc.data_source != "Query Store":
             return
-        sub_stored_queries = [t.table for t in self.get_selected_tables()]
+        sub_stored_queries = [
+            t.table for t in self.get_selected_tables() if t.table != self.doc.name
+        ]
         sync_query_store(sub_stored_queries)
 
     def after_fetch(self, results):