Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

Add Mecanic Job + show water bottle animation + change backpack model #82

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bikouz
Copy link
Contributor

@bikouz bikouz commented Jan 15, 2020

20200115091042_1
20200115091049_1

@bikouz
Copy link
Contributor Author

bikouz commented Jan 15, 2020

Je vous laisse traduire dans les autres langues

Copy link
Owner

@frederic2ec frederic2ec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need pretty good optimization, instead creating function for each color better make it in one

@bikouz bikouz changed the title Add Mecanic Job Add Mecanic Job + show water bottle animation + change backpack model Jan 15, 2020
@frederic2ec
Copy link
Owner

If you want to attach something to the player hand you can user the function : SetAttachedItem more detail here : animation/server.lua

Copy link
Collaborator

@rdlh rdlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, changes requested.

i18n/fr.json Outdated Show resolved Hide resolved
mecanic/client.lua Show resolved Hide resolved
mecanic/client.lua Outdated Show resolved Hide resolved
end
if dialog == colorMenu then
if button == 1 then
CallRemoteEvent("black")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayne rename the event to changeVehicleColor and send the color as an argument to this function?

mecanic/server.lua Outdated Show resolved Hide resolved
end
end)

AddRemoteEvent("black", function(player)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One function to rule them all

@bikouz bikouz requested review from rdlh and removed request for rdlh January 15, 2020 16:03
@bikouz bikouz closed this Jan 16, 2020
@rdlh rdlh reopened this Jan 16, 2020
@bikouz
Copy link
Contributor Author

bikouz commented Jan 17, 2020

20200117195849_1

@GalaxHD551
Copy link
Contributor

GalaxHD551 commented Mar 5, 2020

Should close this pull and make an other, can't edit it any more because the main repository was deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants