(WIP) threads: multicore support for RP2040 #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multiple cores in the runqueue. The current allocation for each core is stored in a new array. Thus, any call to `get_next_for_core` is minimal effort. The allocation is updated after each change in the runqueue.
Export `CoreId`.
Clean code & improve readability.
Optimize case where `N_CORES` == 1.
…into threads/rp2040-multicore
Only schedule a context switch if thread allocation (to a core) changed. TODO: Schedule the context switch on the core that is affected. In most cases, this is the currently running cores, but not always (e.g. when on another core a low priority thread is running that should be preempted).
6 tasks
|
Closing in favor of #397. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PoC that adds multicore support for the Raspberry RP2040.
It introduces a small abstraction layer for SMP (symmetric multiprocessing) support and mostly relies on embassy to implement it for the RP2040.
A first example
threads-multicoreruns, but a lot of this is quite hacky.Concretely, what definitely needs to be fixed is:
riot-rs-runqueuesupport for more than one currently running thread (right now I am doing a very hacky workaround that just works for this example) (edit: runqueue: allocate threads to >= 1 cores #248),I'll do separate Issues/ PRs for the subtasks as listed in the tracking issue #243.
Just thought it would be nice to already open this PR show how easy a first implementation is thanks to embassy 🙂.