Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Homepage #412

Merged
merged 27 commits into from
Sep 7, 2023
Merged

Upgrade Homepage #412

merged 27 commits into from
Sep 7, 2023

Conversation

EliasVal
Copy link
Contributor

@EliasVal EliasVal commented Aug 21, 2023 •
edited
Loading

Changes

(+ Merged #407)

Resolves #411, but not ready yet. Opened PR to allow maintainers to see progress.
Resolves #410

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@EliasVal
Copy link
Contributor Author

EliasVal commented Aug 21, 2023 •
edited
Loading

Upgraded the Get Started section!
I also moved it up since the first thing people usually want to know is how to start using GameCI instead of reading all about it.

@EliasVal
Upgraded getting-started.tsx
a6a6f09 
- Upgraded getting-started.tsx to use company SVGs instead of text
- Moved getting-started.tsx section up
- Updated node16 references to node18 in .md files
@EliasVal
Revamped versions page
d6bdf16
@EliasVal
Merge branch 'main' into upgrade_homepage
db70e9b
@EliasVal
Copy link
Contributor Author

Resolved #410 :)
image

It's not entirely finished, I have to rebuild the builds-table to ditch antd, but it is miles better than what we've got now.

@GabLeRoux
Copy link
Member

much better indeed!

@EliasVal
Copy link
Contributor Author

Progress with tables :D
a lot of code is still commented out instead of removed since I'm still not done here. Left four TODO's in builds.tsx

image

@EliasVal
Starting Section Rework
cffc100 
- Reworked Starting/Opening Section
- Began Working on pricing calculator
- Changed JSX.Element (dep.) -> React.JSX.Element
@EliasVal
Copy link
Contributor Author

Reworked Starting Section
image

Began work on "Pricing Calculator" (Concept):
image

@EliasVal
Created tooltip component
fdf11f3 
- Created tooltip.tsx
- Centered VSC buttons in Getting Started
@EliasVal
Devs that chose us section
ef29646 
- Moved GH, GL, CCI SVGs to /static/assets/images/icons
- 'Finished' Devs that chose us section (more logos needed)
- Reintroduced '.vscode' directory from .gitignore to support @apply rule
@EliasVal
Docker versions progress
61f612f 
- Finished expandable menu
- Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber)
@EliasVal
Tooltip & Docker Table finished
92596cf
@EliasVal
Copy link
Contributor Author

:^)
image

webbertakken
webbertakken approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Few minor comments.

.prettierrc.json Outdated Show resolved Hide resolved
src/components/docs/versions/builds/builds.module.scss Outdated Show resolved Hide resolved
src/components/docs/versions/date-time.tsx Outdated Show resolved Hide resolved
src/components/molecules/tooltip/tooltip.module.scss Outdated Show resolved Hide resolved
src/components/pages/home/section/who-is-using-game-ci-section.tsx Outdated Show resolved Hide resolved
@webbertakken
Copy link
Member

Do you think it would be useful to use the existing approach for indicating when something happens based on an interaction? We already had toasts. I'm thinking we can keep the tooltip for the "click to copy" but then use the toast for the message "xyz copied to clipboard."

image

@EliasVal
Copy link
Contributor Author

EliasVal commented Sep 2, 2023 •
edited
Loading

Do you think it would be useful to use the existing approach for indicating when something happens based on an interaction? We already had toasts. I'm thinking we can keep the tooltip for the "click to copy" but then use the toast for the message "xyz copied to clipboard."

Usure about this, I'll leave it to you. Also the ShowAndCopyChangeSetHashButton does not show up for me.

@webbertakken webbertakken merged commit 62090d3 into game-ci:main Sep 7, 2023
5 checks passed
webbertakken added a commit that referenced this pull request Sep 26, 2023
@webbertakken
Revert "Upgrade Homepage (#412)"
a132831 
This reverts commit 62090d3.
@webbertakken webbertakken mentioned this pull request Sep 26, 2023
Merged
webbertakken added a commit that referenced this pull request Sep 26, 2023
@webbertakken
Revert "Upgrade Homepage (#412)" (#424)
f717e6d 
This reverts commit 62090d3.
GabLeRoux added a commit to GabLeRoux/game-ci-documentation that referenced this pull request Oct 24, 2023
@GabLeRoux
Fix Versions page closes game-ci#410, credits to EliasVal <3
510afa3 
Original author: https://github.com/EliasVal

See game-ci#412
@GabLeRoux GabLeRoux mentioned this pull request Oct 24, 2023
Merged
1 task
GabLeRoux added a commit that referenced this pull request Oct 24, 2023
@GabLeRoux
Fix Versions page closes #410, credits to EliasVal <3 (#432)
8a8a225 
* Fix Versions page closes #410, credits to EliasVal <3

Original author: https://github.com/EliasVal

See #412

* Replace icons with text for better dark and light theme

* Remove extra lines and comments

* Update completed emoji for better dark and light theme

* Update fontSize for arrow icon in versions list
kathywklee pushed a commit to kathywklee/documentation that referenced this pull request Mar 24, 2024
@EliasVal @webbertakken
@AndrewKahr @GabLeRoux @kathywklee
Upgrade Homepage (game-ci#412)
d318f37 
* chore: upgrade docusaurus / fix deprecations

* chore: upgrade docusaurus / fix deprecations

* feat: introduce v3

* chore: upgrade node in ci

* Reconcile v2 and v3 docs with latest unity builder changes. Remove parameters not available in v2 from v2 docs.

* Remove parameters and outputs from v2.2.0-pre

* Update version tags to align with new version

* chore: upgrade docusaurus tsconfig

* chore: import/order

* fix: unresolved import

* chore: versions as client-side block

* fix: firebase resolution

* Re-enable sections, Prettier readme, use LF line endings

* Upgraded getting-started.tsx
- Upgraded getting-started.tsx to use company SVGs instead of text
- Moved getting-started.tsx section up
- Updated node16 references to node18 in .md files

* Revamped versions page

* INCOMPLETE: Changed out Ant's table

* Starting Section Rework
- Reworked Starting/Opening Section
- Began Working on pricing calculator
- Changed JSX.Element (dep.) -> React.JSX.Element

* Created tooltip component
- Created tooltip.tsx
- Centered VSC buttons in Getting Started

* Devs that chose us section
- Moved GH, GL, CCI SVGs to /static/assets/images/icons
- 'Finished' Devs that chose us section (more logos needed)
- Reintroduced '.vscode' directory from .gitignore to support @apply rule

* Docker versions progress
- Finished expandable menu
- Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber)

* Tooltip & Docker Table finished

* pricing section

* disabled unused sections

* resolved requests

---------

Co-authored-by: Webber <webber@takken.io>
Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com>
Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>
@kathywklee kathywklee mentioned this pull request Mar 25, 2024
Merged
3 tasks
webbertakken added a commit that referenced this pull request Mar 25, 2024
@kathywklee @EliasVal
@webbertakken @AndrewKahr @GabLeRoux
Fix issues found when upgrading homepage (#457)
e3cec5b 
* Upgrade Homepage (#412)

* chore: upgrade docusaurus / fix deprecations

* chore: upgrade docusaurus / fix deprecations

* feat: introduce v3

* chore: upgrade node in ci

* Reconcile v2 and v3 docs with latest unity builder changes. Remove parameters not available in v2 from v2 docs.

* Remove parameters and outputs from v2.2.0-pre

* Update version tags to align with new version

* chore: upgrade docusaurus tsconfig

* chore: import/order

* fix: unresolved import

* chore: versions as client-side block

* fix: firebase resolution

* Re-enable sections, Prettier readme, use LF line endings

* Upgraded getting-started.tsx
- Upgraded getting-started.tsx to use company SVGs instead of text
- Moved getting-started.tsx section up
- Updated node16 references to node18 in .md files

* Revamped versions page

* INCOMPLETE: Changed out Ant's table

* Starting Section Rework
- Reworked Starting/Opening Section
- Began Working on pricing calculator
- Changed JSX.Element (dep.) -> React.JSX.Element

* Created tooltip component
- Created tooltip.tsx
- Centered VSC buttons in Getting Started

* Devs that chose us section
- Moved GH, GL, CCI SVGs to /static/assets/images/icons
- 'Finished' Devs that chose us section (more logos needed)
- Reintroduced '.vscode' directory from .gitignore to support @apply rule

* Docker versions progress
- Finished expandable menu
- Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber)

* Tooltip & Docker Table finished

* pricing section

* disabled unused sections

* resolved requests

---------

Co-authored-by: Webber <webber@takken.io>
Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com>
Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>

* Fix deparated error

* Fix logo issue in light mode and update HTML tag structure

* Update HTML tag in dev section

* Fix pricing section color and class name typo

* Update css and optimize logo

* Improve quality

* Update code

---------

Co-authored-by: Elias <46247153+EliasVal@users.noreply.github.com>
Co-authored-by: Webber <webber@takken.io>
Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com>
Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbertakken webbertakken webbertakken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the homepage look a bit more professional The versions page is a bit broken
4 participants
@EliasVal @GabLeRoux @webbertakken @AndrewKahr