Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop vendoring #13

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Drop vendoring #13

merged 5 commits into from
Mar 27, 2024

Conversation

ialidzhikov
Copy link
Collaborator

@ialidzhikov ialidzhikov commented Mar 25, 2024 •
edited
Loading

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:
This PR removes the vendor dir.

Which issue(s) this PR fixes:
Part of #5

Special notes for your reviewer:

Release note:

NONE

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2024
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review labels Mar 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review March 26, 2024 07:37
@ialidzhikov ialidzhikov requested a review from a team as a code owner March 26, 2024 07:37
This was referenced Mar 26, 2024
Merged
Open
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2024
andrerun
andrerun approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@andrerun andrerun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ialidzhikov ialidzhikov mentioned this pull request Mar 27, 2024
Merged
1 task
@ialidzhikov ialidzhikov merged commit 4a090f6 into gardener-attic:main Mar 27, 2024
5 checks passed
@ialidzhikov ialidzhikov deleted the drop/vendoring branch March 27, 2024 15:25
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 27, 2024
@ialidzhikov ialidzhikov mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerun andrerun andrerun approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ialidzhikov @andrerun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot