Improve Windows Installation instructions #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Pecka <peci1@seznam.cz> Signed-off-by: Martin Pecka <peci1@seznam.cz>
2 tasks
Signed-off-by: Martin Pecka <peci1@seznam.cz>
traversaro
approved these changes
Sep 3, 2023
Signed-off-by: Martin Pecka <peci1@seznam.cz>
traversaro
reviewed
Sep 3, 2023
Signed-off-by: Martin Pecka <peci1@seznam.cz>
|
All comments should be resolved now. |
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
mabelzhang
reviewed
Sep 16, 2023
There was a problem hiding this comment.
Some formatting things.
While we're here, I noticed some indentation mistakes in the original page that existed before this PR, so I pushed ab0cf96 to fix them.
Co-authored-by: Mabel Zhang <mabel.m.zhang@gmail.com> Signed-off-by: Martin Pecka <peci1@seznam.cz>
Signed-off-by: Martin Pecka <peci1@seznam.cz>
|
Thanks for the formatting improvements. I turned all WARNINGs into NOTEs. |
mjcarroll
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Going through the Windows install instructions for Harmonic, these are a few changes that will hopefully enable more users to finish the installation.
Test it
Try installing it :-D
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.