EnumIface: suppress deprecation warning #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EnumIterator inherits from std::iterator, which has been deprecated in c++17. There is a fix in gz-common6 but it breaks API, so it can't be merged to Garden. So just suppress the deprecation warning in Garden. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## gz-common5 #540 +/- ##
===========================================
Coverage 83.64% 83.64%
===========================================
Files 90 90
Lines 10243 10243
===========================================
Hits 8568 8568
Misses 1675 1675
|
iche033
approved these changes
Oct 8, 2023
Crola1702
pushed a commit
that referenced
this pull request
Apr 25, 2024
The EnumIterator inherits from std::iterator, which has been deprecated in c++17. There is a fix in gz-common6 but it breaks API, so it can't be merged to Garden. So just suppress the deprecation warning in Garden. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
Crola1702
pushed a commit
that referenced
this pull request
Apr 25, 2024
The EnumIterator inherits from std::iterator, which has been deprecated in c++17. There is a fix in gz-common6 but it breaks API, so it can't be merged to Garden. So just suppress the deprecation warning in Garden. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #505, follow-up to #529.
Summary
The EnumIterator class inherits from std::iterator, which has been deprecated in c++17. There is a fix in gz-common6 (#529) but it breaks API, so it can't be merged to Garden. So just suppress the deprecation warning in Garden.
This should fix the gz-common5 brew builds:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.