Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add missing visibility declarations (#548)" #553

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Revert "Add missing visibility declarations (#548)" #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions profiler/src/RemoteryProfilerImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/

#include "gz/common/config.hh"
#include <gz/common/profiler/Export.hh>

#include "RemoteryProfilerImpl.hh"
#include "gz/common/Console.hh"
Expand All @@ -25,7 +24,6 @@
using namespace gz;
using namespace common;

GZ_COMMON_PROFILER_VISIBLE
std::string rmtErrorToString(rmtError error) {
switch (error) {
case RMT_ERROR_NONE:
Expand Down
2 changes: 1 addition & 1 deletion src/SignalHandler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ using namespace gz;
using namespace common;

// A wrapper for the sigaction sa_handler.
GZ_COMMON_VISIBLE std::map<int, std::function<void(int)>> gOnSignalWrappers;
std::map<int, std::function<void(int)>> gOnSignalWrappers;
std::mutex gWrapperMutex;

/////////////////////////////////////////////////
Expand Down
2 changes: 1 addition & 1 deletion testing/include/gz/common/testing/CMakeTestPaths.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace gz::common::testing
///
/// It is not intended that users will directly construct this, but rather
/// utilize the TestPathFactory.
class GZ_COMMON_TESTING_VISIBLE CMakeTestPaths: public TestPaths
class CMakeTestPaths: public TestPaths
{
/// \brief Constructor from TestPaths
public: using TestPaths::TestPaths;
Expand Down
Loading