Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add missing visibility declarations (#548)" #553

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 9, 2023

🦟 Bug fix

Revert #548 until we can figure out how to fix Windows CI.

Summary

This reverts commit a52a7d2.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This reverts commit a52a7d2.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from marcoag as a code owner November 9, 2023 05:08
@scpeters scpeters requested review from j-rivero, azeey and mjcarroll and removed request for marcoag November 9, 2023 05:09
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #553 (d607b2c) into main (a52a7d2) will not change coverage.
The diff coverage is n/a.

❗ Current head d607b2c differs from pull request most recent head 9f95163. Consider uploading reports for the commit 9f95163 to get more accurate results

@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files          79       79           
  Lines       10213    10213           
=======================================
  Hits         8542     8542           
  Misses       1671     1671           
Files Coverage Δ
profiler/src/RemoteryProfilerImpl.cc 84.13% <ø> (ø)
src/SignalHandler.cc 87.75% <ø> (ø)

@mjcarroll mjcarroll merged commit 57b6f81 into main Nov 9, 2023
9 checks passed
@mjcarroll mjcarroll deleted the scpeters/revert_548 branch November 9, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants