Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model frame data #651

Open
wants to merge 1 commit into
base: bullet_kinematic_feature
Choose a base branch
from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 6, 2024

🦟 Bug fix

Summary

Fix ModelFrameSemantics in dartsim. When a model is added to dartsim, a model frame is also always created. So it looks like we can just look up frames to retrieve model frame data in KinematicsFeature instead of using the root body node (which may be at an offset from the model).

Enabled checks for model frame data in kinematic_features

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Jun 6, 2024
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants