Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreferenced switching-physics-engine tutorial and fix broken … (backport #684) #708

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 20, 2024

🦟 Bug fix

Fixes #

Summary

04-switching_physics_engine is unreferenced in the tutorials page. Instead the 04_physics_engines tutorial is referenced and points to a similar tutorial in gz-sim, but the link is broken. In this change, I've removed the 04-switching_physics_engine tutorial and fixed the link in the 04_physics_engines tutorial.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #684 done by [Mergify](https://mergify.com).

…link in 04_physics_engines (#684)

Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
(cherry picked from commit c5f2954)

# Conflicts:
#	tutorials/04-switching-physics-engines.md
Copy link
Author

mergify bot commented Dec 20, 2024

Cherry-pick of c5f2954 has failed:

On branch mergify/bp/gz-physics7/pr-684
Your branch is up to date with 'origin/gz-physics7'.

You are currently cherry-picking commit c5f2954.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   tutorials/04_physics_engines.md

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: tutorials/04-switching-physics-engines.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automated backport did not include the removal of 04-switching_physics_engine.md which I think is fine since it would be breaking an existing link.

@azeey azeey enabled auto-merge (rebase) December 20, 2024 17:48
@azeey azeey merged commit d4a335a into gz-physics7 Dec 20, 2024
8 of 10 checks passed
@azeey azeey deleted the mergify/bp/gz-physics7/pr-684 branch December 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants