Fix crash in OpticalTactilePlugin by checking for valid visualize pointer #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
ahcorde
approved these changes
Nov 11, 2024
|
https://github.com/Mergifyio backport ign-gazebo6 gz-sim8 gz-sim7 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 57599fb)
Merged
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 57599fb)
Merged
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 57599fb)
Merged
8 tasks
ahcorde
pushed a commit
that referenced
this pull request
Nov 12, 2024
iche033
added a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 57599fb)
iche033
added a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 57599fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2543
Summary
See steps in #2543 to reproduce the crash.
Calling the service to disable the plugin (when it has never been enabled before) will cause a crash because the optical tactile visualization marker pointer is null (not created yet). This PR adds a check to make sure the optical tactile visualization marker pointer is not null before attempting to remove the visualization markers.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.