Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1 commands #710

Merged
merged 3 commits into from
Oct 22, 2024
Merged

M1 commands #710

merged 3 commits into from
Oct 22, 2024

Conversation

jluhrs
Copy link
Collaborator

@jluhrs jluhrs commented Oct 21, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 46.34146% with 66 lines in your changes missing coverage. Please review.

Project coverage is 49.83%. Comparing base (9defe7a) to head (7c7def2).
Report is 131 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/scala/navigate/server/NavigateEngine.scala 0.00% 38 Missing ⚠️
...c/main/scala/navigate/server/tcs/TcsChannels.scala 0.00% 10 Missing ⚠️
...rc/main/scala/navigate/model/NavigateCommand.scala 0.00% 7 Missing ⚠️
...ala/navigate/server/tcs/TcsBaseControllerSim.scala 0.00% 7 Missing ⚠️
...ain/scala/navigate/server/tcs/TcsEpicsSystem.scala 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   52.58%   49.83%   -2.76%     
==========================================
  Files          55       70      +15     
  Lines        2628     3285     +657     
  Branches      230      302      +72     
==========================================
+ Hits         1382     1637     +255     
- Misses       1246     1648     +402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -456,6 +417,20 @@ object NavigateEngine {
}
.map(_._2)
.flattenOption

override def m1Park: F[Unit] = ???
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we implement these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jluhrs jluhrs merged commit bc5ea9a into gemini-hlsw:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants