-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zfin import models #184
Zfin import models #184
Conversation
@sierra-moxon The models I spot-checked look good! Unfortunately there's a bug we discovered in the ART workshop today that affects Noctua Form and ShEx. I'm testing a fix for this right now. Once it's merged into ontobio the models would need to be regenerated. Sorry! |
@sierra-moxon OK, that bug's been fixed in ontobio so, if you git pull from |
@dustine32 - I regenerated the ZFIN models after updating to the latest version of ontobio to pull in the fix. I updated this branch accordingly so you should be able to see the differences here? Could you tell me what I'm looking for to see if it all worked properly with the fix? thanks a bunch! :). I also put in a PR for dev so that we could see it on noctua-dev (and I'm running the shex locally as well). |
@sierra-moxon Oh, that fix should've added
But I just see:
Either code didn't update or there's another bug preventing this. I can eventually try the ZFIN GPAD myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Loaded a few into my Noctua instance checking for state = "production," providedBy
on all individuals and edges, etc.
Here we go! |
round 2 attempt for a clean PR into master of all ZFIN models, without spurious deletes that we saw in: #182
The large number of commits is just a result of the number of files being too long to add in a single commit.
Travis is failing because the logging output is too long - should we just move to github actions?