-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Readme revamp #287
base: master
Are you sure you want to change the base?
WIP: Readme revamp #287
Conversation
@kekoav FYI, I was able to get img working on fedora 31 with cgroupsv2 just by creating a symlink for runc pointing to |
@frezbo That is very nice, does that change the security requirements necessary? Can we run with less privileges? |
I was running as a normal user in a fedora 31 VM. |
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 16 16
Lines 1006 1006
======================================
Misses 1006 1006 Continue to review full report at Codecov.
|
This is exactly how I had to run it to make it work on docker toolbox for windows.. Just dropping it here in case it helps someone. As you can see I added the double quotes for the first --volume |
@ChrisTomAlx Updated to add quotes on both. |
|
||
There is an [APKBUILD](https://pkgs.alpinelinux.org/package/edge/testing/x86_64/img). | ||
|
||
```console | ||
$ apk add img --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing | ||
``` | ||
|
||
#### Arch Linux | ||
##### Arch Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kekoav! Could double-check on this section, please? I believe I ran into a a mistake on line 228:
- $ git clone https://aur.archlinux.org/packages/img.git
+ $ git clone https://aur.archlinux.org/img.git
The current link gives me this:
λ git clone https://aur.archlinux.org/packages/img.git
Cloning into 'img'...
fatal: repository 'https://aur.archlinux.org/packages/img.git/' not found
The suggested one (from aur.archlinux.org) works fine:
λ git clone https://aur.archlinux.org/img.git
Cloning into 'img'...
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (13/13), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 13 (delta 1), reused 13 (delta 1), pack-reused 0
Unpacking objects: 100% (13/13), 2.98 KiB | 2.98 MiB/s, done.
In case you think this fix is out of the scope of your PR, LMK and I'll gladly open one with the fix 😄
BTW, great docs! Looking forward to the section with examples for GitLab CI
and How to include img in Dockerfiles with various bases...
, as the current documentation for that is lacking info -- these sections would help my team and I a ton! I'm more than willing to help with that in case you need 🎉
Let's give the README a much-needed refresh. Let's collaborate on this to make img easier to use, and reduce the time for newcomers to get started.
Some of my goals here:
Resolves #251 .
Table of Contents
I'm experimenting with a depth of 3 to limit noise on the TOC.
TODO
The following areas I still think are weak. I'm perusing common issues and looking for user gaps that could make adoption of img easier.