feat: mnemonic #2338

reneaaron · 2023-04-11T15:06:13Z

Describe the changes you have made in this PR

Have one mnemonic to base other keys on (bitcoin, nostr, liquid, etc)
Signing functionality via window.webbtc
- signPsbt(psbt)
- signSchnorr()?

Resources

https://iancoleman.io/bip39/
https://github.com/satoshilabs/slips/blob/master/slip-0132.md
signPsbt() demo

Screenshots (18/05/23)

src/extension/content-script/onendwebbtc.js

socket-security · 2023-04-15T21:15:19Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

github-actions · 2023-04-15T21:20:58Z

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

src/extension/background-script/actions/nostr/setPrivateKey.ts

src/extension/background-script/bitcoin/index.ts

reneaaron · 2023-06-27T15:35:25Z

src/extension/background-script/mnemonic/index.ts

+
+ derivePublicKey(path: string) {
+ const publicKeyBytes = this._hdkey.derive(path).publicKey;
+ if (!publicKeyBytes) {


changed to return the hdkey object

src/extension/background-script/state.ts

…mnemonic

…ready set

…e objects

…ng it

reneaaron added 5 commits April 2, 2023 21:54

feat: first steps

7aa9a22

feat: untie webbtc from lightning

f0d3544

feat: webbtc & prompts for signPsbt

c7599ea

fix: remove bracket

fe0a2aa

feat: first steps towards psbt

b573f9c

lujakob reviewed Apr 11, 2023

View reviewed changes

src/extension/content-script/onendwebbtc.js Outdated Show resolved Hide resolved

reneaaron added 2 commits April 12, 2023 22:37

fix: impelemented some basic functionality & tests (wip)

7ff1d5d

Merge branch 'master' into feat/mnemonic

914b1aa

rolznz assigned rolznz and reneaaron Apr 17, 2023

reneaaron and others added 18 commits April 17, 2023 14:15

Merge branch 'master' into feat/mnemonic

b38eee4

fix: remove lib from lockfile

6d9c0ba

fix: webbtc

8297383

fix: cleanup test

99c9b2a

Merge branch 'master' into feat/mnemonic

d848511

feat: mnemonic / secret key UI WIP

e12139f

feat: account secret key section styling and copy WIP

eb1536b

feat: backup secret key component WIP

e9e59d0

feat: add copy and confirmation to backup secret key component

be6abfd

feat: scroll to top on options navigation

8871fb1

feat: improve styling in BackupSecretKey screen

90fe854

feat: import secret key screen

96a6a20

chore: display nostr key origin WIP

6e558a3

feat: new advanced nostr settings screen

8f6fa22

feat: store mnemonic and generate nostr derived key WIP

1d1b1ae

fix: show saved mnemonic in backup screen

941df57

chore: reduce duplication in deriving nostr secret key

4b20966

chore: update nostr key not replaced warning

3b2ca07

reneaaron commented Jun 27, 2023

View reviewed changes

src/extension/background-script/actions/nostr/setPrivateKey.ts Outdated Show resolved Hide resolved

reneaaron commented Jun 27, 2023

View reviewed changes

src/extension/background-script/bitcoin/index.ts Show resolved Hide resolved

reneaaron commented Jun 27, 2023

View reviewed changes

src/extension/background-script/bitcoin/index.ts Show resolved Hide resolved

reneaaron commented Jun 27, 2023

View reviewed changes

src/extension/background-script/state.ts Outdated Show resolved Hide resolved

rolznz added 20 commits June 28, 2023 12:56

chore: remove unused types

8746d55

chore: do not export nostr derivation path

0620f84

fix: only show secret key import subsection if account does not have …

efa0605

…mnemonic

fix: get correct account, navigate to account settings if mnemonic al…

0cad988

…ready set

chore: move mnemonic components into subfolder

d5ae8ce

chore: rename nostr advanced settings to nostr settings

f3acf75

fix: rename generateMnemonic function

905ea53

chore: add TODOs to state object

f852ce5

chore: update nostrPrivateKey TODO in state object

bbb1d28

chore: add testnet bitcoin network

9538488

chore: update TODO

1ec9a78

chore: wrap nostr key validation in try-catch

034bdae

fix: make memoized bitcoin object consistent with other memoized stat…

f08c90b

…e objects

chore: simplify mnemonic key derivation functions

e9d99db

chore: rename nostr generatePublicKey to derivePublicKey

f5a35f8

chore: add TODO

2373c8d

fix: make nostr getPublicKey id mandatory

b2c66ee

chore: use api for nostr and mnemonic actions

d84a2a8

fix: make nostr generatePrivateKey action return key rather than savi…

f233b5c

…ng it

chore: use api method instead of msg.request to get account

d458a87

rolznz mentioned this pull request Jun 29, 2023

[Feature] Display profile header for account related pages #2521

Closed

rolznz added 2 commits June 30, 2023 12:18

Merge remote-tracking branch 'origin/master' into feat/mnemonic

9cbc89b

feat: add delete key button in nostr settings screen

2ae38b0

rolznz merged commit aa79930 into master Jun 30, 2023
5 of 6 checks passed

rolznz deleted the feat/mnemonic branch June 30, 2023 05:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: mnemonic #2338

feat: mnemonic #2338

reneaaron commented Apr 11, 2023 •

edited by rolznz

Loading

socket-security bot commented Apr 15, 2023 •

edited

Loading

github-actions bot commented Apr 15, 2023 •

edited

Loading

reneaaron Jun 27, 2023

rolznz Jun 28, 2023

feat: mnemonic #2338

feat: mnemonic #2338

Conversation

reneaaron commented Apr 11, 2023 • edited by rolznz Loading

Describe the changes you have made in this PR

socket-security bot commented Apr 15, 2023 • edited Loading

github-actions bot commented Apr 15, 2023 • edited Loading

reneaaron Jun 27, 2023

Choose a reason for hiding this comment

rolznz Jun 28, 2023

Choose a reason for hiding this comment

reneaaron commented Apr 11, 2023 •

edited by rolznz

Loading

socket-security bot commented Apr 15, 2023 •

edited

Loading

github-actions bot commented Apr 15, 2023 •

edited

Loading