Extract presence viewer web code only for Swift #7
Conversation
|
|
||
| public struct DittoPresenceViewerResources { | ||
| // These public accessors let consuming packages (e.g. DittoSwiftTools) use the bundled resources (JS & HTML) from this package | ||
| public static let webDistDirURL = Bundle.module.bundleURL.appendingPathComponent("Resources/dist") |
There was a problem hiding this comment.
Caveat: I don't fully understand how this is used in practice in the swift tools project.
I noticed that Resources/dist dir you are referencing doesn't exist - should it?
Also it's not a change that is part of this repo but I can see that the HTML/JS/CSS files are also located in Shared/ top level dir - is it intentional?
There was a problem hiding this comment.
To see this in use, you can take a look at getditto/DittoSwiftTools#166.
Resources/dist isn't part of whats here, but I think its generated or used at runtime. For that, I moved the logic we used to have in DittoSwiftTools here and left it generally unchanged.
Yes, there's currently duplication, but we can't fix that until we're able to use swift-tools 6.0 everywhere due to swiftlang/swift-package-manager#6982. Once this is merged I'll open a draft PR to remove the duplication & update swift tools but that will likely have to sit for a while until we're ready for everything to use Swift 6.
There was a problem hiding this comment.
I'm going to leave a draft PR (#8) open to track removing this duplication long-term whenever we're able to move to swift-tools 6.0
There was a problem hiding this comment.
And here is this used in the POS demo app, showcasing no breaking changes for consuming apps: getditto/demoapp-pos-kds#69
Instead of the original approach, I'm now extracting only the JS and HTML web content to here, and keeping everything else in DittoSwiftTools. This should massively simplify the cutover and avoid potentially painful breaking changes for end users.
As such, this will fully replace the current way I was testing, and will result in a 2.0.0 release of this package.
To see this change in action, see getditto/DittoSwiftTools#166
Part of CXTOOLS-337
Part of CXTOOLS-358