Don't duplicate webview resources #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's also a missing piece here to link things properly after #7 lands, will update once that's merged. |
… at the root path.
bplattenburg
force-pushed
the
BP/dont_duplicate_resources_for_swift
branch
from
bf521ff to
e6ead08
Compare
Updated, this ready to go whenever we're ready to move to Swift 6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a limitation in Swift Package Manager, today we have to duplicate our webview resources from
SharedintoSwift/Sources/DittoPresenceViewerCore/Resourcesbecause SPM won't let you reference resources within the repository but outside of the package root.This removes that duplication, but it requires us to move to swift-tools 6.0 here and in DittoSwiftTools, marking as a draft until we are ready to do that.