ref(project-cache): Check revision before loading from Redis #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/project-config-redis-rev
branch
2 times, most recently
from
382d427
to
c97c47d
Compare
Dav1dde
force-pushed
the
dav1d/project-config-redis-rev
branch
from
c97c47d
to
8c929dc
Compare
Dav1dde
force-pushed
the
dav1d/project-config-redis-rev
branch
from
9d81609
to
77fcb34
Compare
Dav1dde
added a commit
that referenced
this pull request
Aug 14, 2024
Switches the regex implementation for globs from `regex` to regex-lite`, this should bring down memory consumption for all globs. This is just a temporary stop-gap to unblock the project cache improvements started in #3892, eventually the glob implementations should be unified and ideally be as much as possible regex free.
Dav1dde
added a commit
that referenced
this pull request
Aug 14, 2024
Dav1dde
added a commit
that referenced
this pull request
Aug 28, 2024
Follow-up to to #3892, now also implements the revision fetching in the project config API. Sentry does not need to be updated and this is not a breaking change and works with any combinations of Relays. Extends the project config API with another field `revisions` which optionally contains the revisions for all requested public keys. If there are are revisions, the response is extended with a field `unchanged` which contains all project keys which were unchanged (have the same revision), similar to how `pending` is handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the 'new' revision key before actually loading and parsing the project config.
Revision introduced here: getsentry/sentry#75523
Change is backwards compatible, if the key is missing the check is simply skipped.
I was considering propagating the information whether something was refreshed or a fresh fetch through the state channel, but after review and consideration, I don't think that is useful information, we still have to reset a bunch of internal state and move the project out of the
in flightstatus. All if which we already do, the only thing we could change is skipping the assignment of the project info contained in the project fetch state (because that's the same state as the old), but this is already only anArc.Still needs:
Disabled states also need to remember their revision. Maybe we skip this, since disabled states are generally very small and quick, but for consistency sake it should be there.Disabled states don't have a revision currently, they currently have no metadata and are just{"disabled": true}. In a followup we can think about introducing a revision for disabled states as well (or checking before & after for disabled).Integration tests!#skip-changelog