feat(spans): Infer span.op if not defined

[jjbayer]

Add global option that allows inferring the span op, with rules like this:

{
    "span_op_defaults": {
       "rules": [{
            "condition": {
                "op": "not",
                "inner": {
                    "op": "eq",
                    "name": "span.data.messaging\\.system",
                    "value": null,
                },
            },
            "value": "message"
        }]
    }
}

ref: #3637

[Dav1dde]

Can we not build this into the existing Rule system or extend it? I'd prefer if we had a generic system instead of adding more specific stuff. Now it's the span.op in the future it might be span.foo. This is close to being a system which can write attributes based on rules.

[Dav1dde]

Untested:

Suggested change

	for rule in self.rules {
	if rule.condition.matches(span) {
	return rule.value.clone();
	}
	}
	"default".to_owned()
	self.rules.iter()
	.find(|rule| rule.condition.matches(span))
	.cloned()
	.unwrap_or("default".to_owned())

[jjbayer]

I kind of like the for loop, even though it takes one more line.

[jjbayer]

I'd prefer if we had a generic system instead of adding more specific stuff. Now it's the span.op in the future it might be span.foo. This is close to being a system which can write attributes based on rules.

@Dav1dde I considered it, the question is always, where do we stop? This PR is already a generalization of the initial idea of slapping some hard coded rules onto span normalization. But I agree that I could at least make the target field (span.op) part of the configuration, and make it independent of spans (the selector has $span... in it anyway).

[Dav1dde]

considered it, the question is always, where do we stop? This PR is already a generalization of the initial idea of slapping some hard coded rules onto span normalization.

Fair enough.

But I agree that I could at least make the target field (span.op) part of the configuration, and make it independent of spans (the selector has $span... in it anyway).

I'd like that, but that may require a Setter trait.