Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(angular): Add code snippets for app.config.ts-based Angular apps #11356

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 13, 2024

Following getsentry/sentry#77134 in the product, this PR now also adds code snippets for AppConfig-bsaed Angular apps to our Docs.

I opted for displaying the snippets in tabs next to each other (1 tab for app.config.ts vs app.module.ts).

closes #8342

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 6:59am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 6:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 6:59am

@Lms24 Lms24 requested review from a team, mydea, AbhiPrasad and ArthurKnaus and removed request for a team September 13, 2024 13:45
@Lms24 Lms24 self-assigned this Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes ⬇️
sentry-docs-edge-server-array-push 257.01kB 3 bytes ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, but otherwise this looks great!

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@Lms24 Lms24 enabled auto-merge (squash) September 17, 2024 06:44
@Lms24 Lms24 merged commit 40d437e into master Sep 17, 2024
10 checks passed
@Lms24 Lms24 deleted the lms/ref-angular-app-config-setup branch September 17, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Angular SDK installation for standalone component Angular projects
4 participants