Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mobile app profiling metrics #7660

Merged
merged 14 commits into from
Sep 20, 2023
Merged

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Aug 16, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Convert the current mobile app profiling page to a directory base, and add a new subpage explaining the metrics we collect for profiling.

Extra resources

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 0:50am

Copy link
Member

@indragiek indragiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to mentioning constants like THREAD_BASIC_INFO and TASK_VM_INFO we should mention that the actual API used to retrieve the info is thread_info and task_info, respectively.

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some language suggestions, but otherwise this looks good!

@armcknight armcknight merged commit 1d55231 into master Sep 20, 2023
7 checks passed
@armcknight armcknight deleted the armcknight/docs/profiling-metrics branch September 20, 2023 03:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants