Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): De-couple button from modal #7876

Merged
merged 3 commits into from
Sep 19, 2023
Merged

ref(feedback): De-couple button from modal #7876

merged 3 commits into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. ref(feedback): De-couple button from modal 

    De-couple the feedback button from the modal so that we can show the modal using other components as the actor.

This change does the following:

* Move the form in `<FeedbackModal>` to `<FeedbackForm>`
* Move business logic of the modal/form into `<FeedbackModal>` (from `<FeedbackWidget>`)
* `<FeedbackModal>` requires `children` as a render function
* `<FeedbackWidget>` is refactored to use new `<FeedbackModal>` and remains the same (shows our `<FeedbackButton>` which controls the modal)
    @billyvg
    billyvg committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    336ddf5 View commit details
    Browse the repository at this point in the history

  2. ref

    @billyvg
    billyvg committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b8478ce View commit details
    Browse the repository at this point in the history

  3. style(lint): Auto commit lint changes

    @getsantry @billyvg
    getsantry[bot] authored and billyvg committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f84f57a View commit details
    Browse the repository at this point in the history