ref(feedback): De-couple button from modal #7876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
De-couple the feedback button from the modal so that we can show the modal using other components as the actor. This change does the following: * Move the form in `<FeedbackModal>` to `<FeedbackForm>` * Move business logic of the modal/form into `<FeedbackModal>` (from `<FeedbackWidget>`) * `<FeedbackModal>` requires `children` as a render function * `<FeedbackWidget>` is refactored to use new `<FeedbackModal>` and remains the same (shows our `<FeedbackButton>` which controls the modal)
billyvg
force-pushed
the
ref-feedback-decouple-feedback-button-and-modal
branch
from
ef5cd5d
to
f84f57a
Compare
ryan953
reviewed
Sep 19, 2023
Comment on lines
+109
to
+110
| <Header>{title}</Header> | ||
| {open && <FeedbackForm onSubmit={handleSubmit} onClose={handleClose} />} |
There was a problem hiding this comment.
nit: but i'd put the Header inside the form.
{open && seems like it's in a weird spot.. but not a problem. Lets see, the Dialog also has it's open, which is driving the animation (also Content animation).. so this open is controlling what extra dom nodes are on the page. So proof i read everything 👍
There was a problem hiding this comment.
I opted to not render the form when it's not visible as to also kill the form state when the modal is closed (there was some useEffect/ref shenanigans going on from the hackweek project).
I had Header in Form initially, but moved into into modal to avoid passing title to another component
ryan953
approved these changes
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-couple the feedback button from the modal so that we can show the modal using other components as the actor.
This change does the following:
<FeedbackModal>to<FeedbackForm><FeedbackModal>(from<FeedbackWidget>)<FeedbackModal>requireschildrenas a render function<FeedbackWidget>is refactored to use new<FeedbackModal>and remains the same (shows our<FeedbackButton>which controls the modal)